rubycas / rubycas-server

Provides single sign-on authentication for web applications, implementing the server-end of Jasig's CAS protocol.
http://rubycas.github.com
Other
628 stars 270 forks source link

Fix broken tests for newer ruby and rspec #245

Closed ducktyper closed 8 years ago

ducktyper commented 9 years ago

Rspec uses 'instance_exec' instead of 'instance_eval' if ruby supports it (from about 1.9 I believe). Two tests were failed from this difference and now fixed.

mitfik commented 8 years ago

Just tested all major version of ruby with our tests and everything seems to be ok. (1.9, 2.0 and 2.1). I am closing that PR since it seems is not needed. Please check if the problem still appear and if so provide more details how to recreate it. Please also provide some more information about rspec and instance_exec vs instance_eval (maybe some official documentation?) and if possible rspec version which you are using.