search

rubycdp / ferrum

Headless Chrome Ruby API
https://ferrum.rubycdp.com
MIT License
1.71k stars 123 forks source link

Quote browser path to handle spaces #245

Closed ttilberg closed 2 years ago

ttilberg commented 2 years ago

My browser path on MacOS is "/Applications/Google Chrome.app/Contents/MacOS/Google Chrome" which was not getting properly escaped when launching to get version.

Additionally, it looks like command is only used to get the browser path for printing --version and can be simplified.

route commented 2 years ago

Correct! Thanks