Open postmodern opened 1 year ago
@route would appreciate some guidance on this new feature and where I should add the specs and documentation?
@postmodern I was reorganizing specs so currently page specs are in the browser_spec. I think we can create page_spec and put it there. Though it overlaps with network_spec a bit, because page.on(:request)
only works with interception, but page.on(:response) works without it. I'm now thinking that maybe it's better to use something like page.network.on(:request | :response | :auth)
. Need to experiment with that...
I can't say for certain, but I believe the act of enabling network intercept requires you to authorize the requests to proceed. For example, some of the specs show:
https://github.com/rubycdp/ferrum/blob/main/spec/network/exchange_spec.rb#L28
network.intercept
page.on(:request) { |r, _, _| r.continue }
@ttilberg hmm that solved the exception, except now it does not appear that my on(:response)
callback is being called back.
@postmodern I took a look but didn’t find a CDP event translation helper for on(:response)
. However, in an earlier issue I noted and used network.responseReceived
, might this get you on your way?
https://github.com/rubycdp/ferrum/issues/197#issue-1009903139
Edit: haha… I just looked at the rest of the context of this issue… lol. I’ll see myself out!
@ttilberg yeah it's added in this PR. Feel free to pull my branch and try to mess with it. I swear it was working last year.
OK I added some echo debugging and the @client.on('Network.responseReceived')
callback is being called, but it's not finding the exchange object for the given params['requestId']
, so the passed in block
is never called.
Got it, I needed to do network.select
from the context of Ferrum::Page
.
I wanted to be able to have a callback similar to
on(:request)
but triggered once a response was received. This adds an additional callback for theNetwork.responseReceived
event when a response is received. It will look up theFerrum::Network::Exchange
object with the matchingrequestId
and passes it back to the block, once a response has been received for a request.I didn't know where to add specs for this, since there does not appear to be specs for
Ferrum::Page
or aspec/page_spec.rb
file? I also didn't know where I should mentionbrowser.on(:response)
in the README, sincebrowser.on(...)
is only mentioned in conjunction to usingbrowser.network.intercept
.