Closed francisbeaudoin closed 1 year ago
As the Exchange object is pushed to the network traffic before assigning its request, it is assumed that the request can be nil in the exchange object.
Exchange
request
nil
https://github.com/rubycdp/ferrum/blob/d14161363c0a7b75c23f9c37a382eb838fa4b76b/lib/ferrum/network.rb#L355-L357 https://github.com/rubycdp/ferrum/blob/d14161363c0a7b75c23f9c37a382eb838fa4b76b/lib/ferrum/network.rb#L368
For that reason, the #navigation_request? method was updated to be nil safe.
#navigation_request?
Details
As the
Exchangeobject is pushed to the network traffic before assigning itsrequest, it is assumed that therequestcan benilin the exchange object.https://github.com/rubycdp/ferrum/blob/d14161363c0a7b75c23f9c37a382eb838fa4b76b/lib/ferrum/network.rb#L355-L357 https://github.com/rubycdp/ferrum/blob/d14161363c0a7b75c23f9c37a382eb838fa4b76b/lib/ferrum/network.rb#L368
For that reason, the
#navigation_request?method was updated to benilsafe.