Closed singhprd closed 10 months ago
Yep, I was looking at this flag for a while, and I think it's good idea to turn it on by default instead of headless=true
Any chance we can get this PR merged and released in a new version soon?
@JacobEvelyn I don't see any PR
Oh sorry; I thought @singhprd's draft PR linked above was in this repo instead of a fork. @singhprd do you want to turn it into a PR here? @route @singhprd would it be helpful if I did?
@JacobEvelyn don't ask, do if you can ;) Apparently it's not that easy as turn on new mode, as there are a lot of failing tests.
As I can see it's not that easy as new Chrome works differently with frames, but I started to work on this.
is it merged?
There’s nothing to merge yet
Hello!
I have just read this: https://developer.chrome.com/articles/new-headless/
TLDR:
I was wondering about starting a discussion here - should Ferrum default to setting
--headless=new
?There might be more to do that just update the option here so it'd be great to hear thoughts?: https://github.com/rubycdp/ferrum/blob/main/lib/ferrum/browser/options/chrome.rb#L8
Proof of concept update from my fork here: https://github.com/fac/ferrum/pull/8/files