search

rubycdp / ferrum

Headless Chrome Ruby API
https://ferrum.rubycdp.com
MIT License
1.76k stars 127 forks source link

Better handling of ws_url, and avoid stripping query params from url #447

Closed Aubermean closed 8 months ago

Aubermean commented 9 months ago

Hi,

This fixes some compatibility issues with browserless v2 and possibly others.

An issue with the parse_json_version was that it would turn the ws scheme into http, strip query params and request /json/version. This is the first problem, stripping query params which often include an auth token and other configuration.

The second concern was that the initializer would override the ws_url based on what that endpoint would show, in the case of browserless that would be 0.0.0.0:3000. If the ws_url has been set, ferrum should not try to override that.

This is my first OSS PR so I am sorry if I did some thing wrong.

439

route commented 9 months ago

Tests are failing

route commented 8 months ago

Merged with other fixes manually.