Add base64 to runtime dependencies for Ruby 3.4 compatibility

rubycdp / ferrum

Headless Chrome Ruby API

https://ferrum.rubycdp.com

MIT License

1.76k stars 127 forks source link

Add base64 to runtime dependencies for Ruby 3.4 compatibility #476

Closed tisba closed 3 months ago

tisba commented 3 months ago

See https://github.com/ruby/ruby/blob/master/doc/NEWS/NEWS-3.3.0.md#stdlib-updates

With Ruby 3.4 on forward, base64 will no longer be available as part of part of the default gems. It needs to be an explicit dependency going forward.

tisba commented 3 months ago

Dear maintainers, let me know if you want me to fix the linting errors too. I kept the change in this PR to a minimum for now.

route commented 3 months ago

Let's fix linter and I'll merge!

tisba commented 3 months ago

Linters are happy. The now failing Ferrum::ProcessTimeoutError for Ruby 2.7 looks like an intermittent error.

route commented 3 months ago

Thanks!