search

rubycdp / vessel

Fast high-level web crawling Ruby framework
https://vessel.rubycdp.com
MIT License
645 stars 11 forks source link

Update README.md #8

Closed glaucocustodio closed 3 years ago

route commented 3 years ago

Honestly I think it will be mostly a duplicate of Ferrum's docs, so it's better to mention that inside a method there's Ferrum::Page available and show the link to Ferrum's docs. Otherwise we'd have to copy/paste everything not only screenshots ;)

glaucocustodio commented 3 years ago

I see your point, the thing is that ferrum's doc shows creation of a browser object (browser = Ferrum::Browser.new), not a Ferrum::Page. Looking the code we can see that method calls to browser delegates to a page, but it's not very clear for people not familiar with the guts of the gem. We can make it clear that for screenshot for instance, calling page.browser.screenshot is not the same as page.screenshot.

route commented 3 years ago

I agree though it's Ferrum's docs that are missing to explain it. I like ### Headful mode section this is definitely explains vessel, as for Ferrum I'd rather put a link to Ferrum's docs and cover architecture points there.

route commented 3 years ago

Thank you!