Closed joshpuetz closed 3 years ago
Thanks for doing this @joshpuetz! One question: we don't typically include the language version dotfiles. The Gemfile handles that now for Ruby. There doesn't seem to be a Node analog in Rails, though. Do you usually commit both the .nvmrc
and .ruby-version
files in your repos, or just the .nvmrc
?
We typically include both as many people on our team use both rvm
and nvm
to manage multiple rubies and nodes.
That said I've changed the travis.yml
file to include the nvm version and not require the .nvmrc
file anymore!
This PR makes several tweaks to allow the CFP app to run on Travis out of the box:
Gemfile
, so this PR sets that same Ruby version intravis.yml
to avoid errors from Travis about conflicting Ruby versions.bundle
,nvm
, andyarn
installation comments to thetravis.yml
file to make sure Travis test runs have everything available need to run the RSpec test suite..nvmrc
file to specify the required version of node to be installed