rubycentral / cfp-app

Rails app for managing a conference CFP
MIT License
224 stars 155 forks source link

Change Travis configuration to run out of the box #222

Closed joshpuetz closed 3 years ago

joshpuetz commented 3 years ago

This PR makes several tweaks to allow the CFP app to run on Travis out of the box:

barrettclark commented 3 years ago

Thanks for doing this @joshpuetz! One question: we don't typically include the language version dotfiles. The Gemfile handles that now for Ruby. There doesn't seem to be a Node analog in Rails, though. Do you usually commit both the .nvmrc and .ruby-version files in your repos, or just the .nvmrc?

joshpuetz commented 3 years ago

We typically include both as many people on our team use both rvm and nvm to manage multiple rubies and nodes.

That said I've changed the travis.yml file to include the nvm version and not require the .nvmrc file anymore!