Closed jonsgreen closed 2 years ago
My general preference is for a separate tiny PR but it’s fine for this PR to keep it here with a note.
On Tue, Apr 12, 2022 at 10:21 AM Jonathan @.***> wrote:
@.**** commented on this pull request.
In app/models/speaker.rb https://github.com/rubycentral/cfp-app/pull/249#discussion_r848681802:
@@ -75,6 +75,10 @@ def gravatar_hash
info :text
created_at :datetime
updated_at :datetime
+# age_range :string +# ethnicity :string +# first_time_speaker :boolean +# pronouns :string
@adarsh https://github.com/adarsh normally the annotate models task gets run automatically but somehow this must have not been run in a recent migration so it did not get committed. This is going to keep showing up so we should either just accept it as part of this PR or I can make a separate tiny PR for it.
— Reply to this email directly, view it on GitHub https://github.com/rubycentral/cfp-app/pull/249#discussion_r848681802, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAG7CXP42AW2WQ25C372HF3VEWWIJANCNFSM5THCKE7A . You are receiving this because you were mentioned.Message ID: @.***>
-- Sent from my mobile
Summary
This PR covers a very minimal feature of an "Organizer Creating a Event Website". It merely builds out the initial model and some basic routes, controller, views and authorization that will be built upon in upcoming PRs.
The Website model, while currently just an association to the Event model, will soon be used for data and logic needed for configuration of the website. It also will help keep the logic and associations related to the website generation and presentation isolated from the Event god object.
The PR tries to mostly follow existing patterns (e.g. navigation/sub-navigation) without getting lost in possible refactorings. However, the decent_exposure gem was added for developer happiness.
Commit Notes