rubycentral / cfp-app

Rails app for managing a conference CFP
MIT License
223 stars 154 forks source link

Link some pages from footer #281

Closed jonsgreen closed 2 years ago

jonsgreen commented 2 years ago

Link some pages from footer

Reason For Change

From Miro Card:

As a designer I'd like some pages to be linked to in the footer of the site navigation, to take advantage of that real estate on a screen.

I'd like to be able to group these pages into categories and have them displayed under their respective categories.

This PR attempts to satisfy the desire for grouping footer links to pages under categories in the footer with some minimal data modeling. For simplicity just a string array field was added for configuration on the website which populates a select list to choose from for a page. There is a slight cost of brittleness should category names need to be changed at some point but should hopefully be sufficient for MVP.

This was also a good opportunity to more fully wire up the footer and header to better match the current design. Some improvements to image handling when missing and resizing for svgs was included as well.

Changes

Link some pages from footer