rubycentral / cfp-app

Rails app for managing a conference CFP
MIT License
224 stars 155 forks source link

Update schedule page - Program page filter #292

Closed codyjamesbrooks closed 2 years ago

codyjamesbrooks commented 2 years ago

Reason for Change

This PR attempts to solve the following

Changes

Here is an overview of some of the major changes

Minor

There is some early coupling that is happening between the fly out and the filter. The method that I implemented required this, and it felt easiest option given the time line. I will think on better separating those two features as I implement the filter on the schedule page.

Also of note is that I am going to switch the direction the filter. Currently it is an 'excell' style filter, where all filter options default to 'checked', then inputs allow for removal of DOM elements. For our purposes I believe we want this working in the other direction (default to 'unchecked', filer application only shows 'checked' items

Also this guy needs to write some tests!

Who doesn't love a preview

Screen Recording 2022-05-13 at 10 32 05 AM

https://link.to/task_tracker_card