I was recording a loom video to go over the 'adding sponsors to an Event' in the CFP. And while I was recording the video there were some things that really stood out as feeling as though they really needed to be improved.
Some of the things are small. A little bit of CSS over here, a data validation sprinkled in over there.
Some of the things were actual oversights, that would have been flushed out with more testing and use.
The commit message has a detailed accounting of everything that the PR seeks to accomplish, And I have included tests on all of the behavior that I noticed that I wanted to ensure was correct.
Changes
Here is a list of all of the Sponsor related updates
adding padding, and max-width to sponsors containers on the sponsors page
properly style the page title to the sponsors page
order sponsors on index
resize sponsor primary logo
add sponsor star the the data that is sent back from the .js time slot form
properly scope the query to pull an websites events sponsors on the sponsors show page
require sponsors have a name, tier, url, description, and lastly a primary_logo
remove 'other_title' from the sponsor model
modify sponsors index to indicate if the sponsor has a footer_logo or a banner_ad present
Here are the updates that are not sponsor related, and are more general application cleanup
fixed up some CSS class duplication
allow tags on programs page to wrap rather than overflow their container
adarsh
commented
2 years ago
Reason for Change
I was recording a loom video to go over the 'adding sponsors to an Event' in the CFP. And while I was recording the video there were some things that really stood out as feeling as though they really needed to be improved.
Some of the things are small. A little bit of CSS over here, a data validation sprinkled in over there. Some of the things were actual oversights, that would have been flushed out with more testing and use.
The commit message has a detailed accounting of everything that the PR seeks to accomplish, And I have included tests on all of the behavior that I noticed that I wanted to ensure was correct.
Changes
Here is a list of all of the Sponsor related updates
Here are the updates that are not sponsor related, and are more general application cleanup