jonsgreen commented 2 years ago

Reason for Change

While working on Loom videos I uncovered some critical bugs. Sponsors were not being scoped to the website/event. Clearly that would have eventually been discovered but it is nice to catch it now. A trickier bug was the on the schedule page which could not be accessed when using the custom domain because it was requiring an event. In general it is best to go through current_website for website pages since it contains all the logic to determine the correct website/event based on the domain, slugs and routes. These fixes are backed by feature specs to prevent regressions.

Finally, there is a bug fix for the problem that Devon identified in which indenting is lost when switching between TinyMCE and CodeMirror.

Changes

scopes sponsors to current event on sponsors page
retrieves schedule through website rather than event to support custom domain access to schedule page
fixes indenting when going back from TinyMCE and CodeMirror

codeclimate[bot] commented 2 years ago

Code Climate has analyzed commit 1d052f67 and detected 0 issues on this pull request.

View more on Code Climate.

adarsh commented 2 years ago

Hey @jonsgreen - can we do each of these bugs as separate PRs please?

jonsgreen commented 2 years ago

@adarsh Sorry, I should have closed this one already since I did break it up into different PRs as requested. That was a good idea.

rubycentral / cfp-app

Bug-Fixes #303

Reason for Change

Changes