search

rubychan / coderay

Fast and easy syntax highlighting for selected languages, written in Ruby.
http://coderay.rubychan.de/
Other
846 stars 115 forks source link

Why `test/{executable,lib,unit}/*` are not included in the gem file? #205

Closed junaruga closed 7 years ago

junaruga commented 7 years ago

Why are only test/functional/* files included in the gem file?

coderay.gemspec

s.files = git ls-files -- lib/* test/functional/* Rakefile #{readme_file} MIT-LICENSE.split("\n") s.test_files = git ls-files -- test/functional/*.split("\n")

Why test/{executable,lib,unit}/* are not included?

korny commented 7 years ago

You're right, that doesn't make sense. I think tests should not be part of the gem distribution at all though. What's your opinion?

junaruga commented 7 years ago

You're right, that doesn't make sense. I think tests should not be part of the gem distribution at all though. What's your opinion?

My opinion is same with you. The tests should not be part of the gem distribution. And Rakefile too.

junaruga commented 7 years ago

Hi @korny can you check my PR #207 ? Thanks.

korny commented 7 years ago

Thanks!