search

rubychan / coderay

Fast and easy syntax highlighting for selected languages, written in Ruby.
http://coderay.rubychan.de/
Other
846 stars 115 forks source link

Drop ruby 1.8-1.9-2.0-2.1-2.2-2.3 support #247

Closed deivid-rodriguez closed 2 years ago

deivid-rodriguez commented 4 years ago

Hello! :wave:

What do you think about dropping support for very old rubies such as 1.8.7 or 1.9.3?

deivid-rodriguez commented 4 years ago

Hello! Any interest on this? :)

grosser commented 4 years ago

@korny this too ideally 🎉

korny commented 4 years ago

Thank you for the cleanup suggestions! The plan is to drop support for older ruby versions in version 2.0, but not before. Is there anything here that is actually a problem for current users?

deivid-rodriguez commented 4 years ago

No idea since I don't use old rubies, I might work or it might not.

What I know is that the library does not pass its own tests on both ruby 1.8 and ruby 1.9. My intention when opening this PR was to get CI green, but since there was many other rubies that have already reached their End of Life, I figured I would go all the way and drop support for everything not supported upstream.

Users of old rubies can still stick to previous versions, and version managers will gracefully handle that, so I don't see any issues with dropping support. But of course it's up to you! :)

korny commented 4 years ago

What I know is that the library does not pass its own tests on both ruby 1.8 and ruby 1.9.

CI must be green, I agree. But it's the gems setup that is breaking every few months, not CodeRay. I fixed it again on master :)

deivid-rodriguez commented 4 years ago

Sure, fixing the CI also works, I just thought it would be easier to just kill the whole thing :laughing:.

Thanks for fixing it and for the release :)

deivid-rodriguez commented 4 years ago

I rebased this PR in case you're ready to go to 2.0 :)

codeclimate[bot] commented 4 years ago

Code Climate has analyzed commit a5d9fe72 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 77.3% (-0.2% change).

View more on Code Climate.

deivid-rodriguez commented 4 years ago

Also, note that you have fixed CI for ruby 1.9, but ruby 1.8 is still broken. I don't know a single library testing successfully against ruby 1.8 in 2020, it sounds like an interesting challenge :)

deivid-rodriguez commented 4 years ago

Actually, I do! RSpec does it: https://travis-ci.org/github/rspec/rspec-core. Maintenance giants there!

deivid-rodriguez commented 2 years ago

I don't like to let PRs hang so long, so I'll close this!