search

rubyconfig / config

Easiest way to add multi-environment yaml settings to Rails, Sinatra, Padrino and other Ruby projects.
Other
2.1k stars 230 forks source link

Add Ruby 3.2 to test matrix #337

Closed y-yagi closed 1 year ago

y-yagi commented 1 year ago

Hmm. It seems CI is broken now. https://github.com/rubyconfig/config/actions/runs/4876081705/jobs/8699118492

pkuczynski commented 1 year ago

Hmm. It seems CI is broken now. rubyconfig/config/actions/runs/4876081705/jobs/8699118492

Looks like it is. Not sure why, but it can't run appraisal anymore

pkuczynski commented 1 year ago

I fixed CI. It was broken for some time and I didn't noticed. Let's see if your PR pass through...

pkuczynski commented 1 year ago

Unfortunatelly 3.2 fails with appraisal, but I am not sure why and I won't have time to work on it. Would you like to spare some time for it?

y-yagi commented 1 year ago

@pkuczynski Thanks for your help! I assume the released appraisal has a problem with the latest bundler. So I've changed to use appraisal from the git. Ref: https://github.com/thoughtbot/appraisal/issues/210

I confirmed this work on my local fork. https://github.com/y-yagi/config/actions/runs/5073993153/jobs/9113686334?pr=2

pkuczynski commented 1 year ago

I don't think this is a best idea and I would prefer to use appraisals from rubygem. Maybe you could reach out to their repo and report a bug? Maybe they will release new version soon?

y-yagi commented 1 year ago

OK. The issue already exists(I mentioned it in my before comment). I just added a comment.

y-yagi commented 1 year ago

The new version of appraisal released. https://github.com/thoughtbot/appraisal/commit/feb78bcc6177038399bff098cb6c2bd4bca4972a

I removed the commit related to appraisal and it seems to work well https://github.com/y-yagi/config/actions/runs/5561411613

pkuczynski commented 1 year ago

Thanks!