rubyconfig / config

Easiest way to add multi-environment yaml settings to Rails, Sinatra, Padrino and other Ruby projects.
Other
2.11k stars 230 forks source link

Heroku Compatibility #84

Open jamesy829 opened 10 years ago

jamesy829 commented 10 years ago

I use the suggested guide to setup usage of env variables on Heroku

https://github.com/railsconfig/rails_config#working-with-heroku

I have my env variables on Heroku as following:

Settings.database.dbname: value
Settings.keys.aws_access_key_id: value
Settings.keys.aws_secret_access_key: value
Settings.keys.devise_secret_key: value
Settings.keys.directory: value
Settings.keys.region: value
Settings.keys.secret_key_base: value

I noticed that when it tries to run rake task, it would complain env variables not found, and doing some digging, I discovered those are not valid env variables and Rails would not pick them up properly.

I have pushed those env variables using the rake task provided bundle exec rake rails_config:heroku

Is this a valid bug or the expected behaviour? If its not a bug, what's the approach I should be taking.

Thanks in advance.

jamesy829 commented 10 years ago

Found a possible work around

https://github.com/finnlabs/rails_config-env_source

Giving it a shot and if works, submit a PR to merge

jamesy829 commented 10 years ago

I have confirmed using this and the specified format of environment variables will allow the deployment to Heroku work properly, would be nice to have this as part of this gem

fredwu commented 9 years ago

Great work! Any chance of submitting a PR? :)

pkuczynski commented 3 years ago

@cjlarose do you think it makes sense to add any of this to our source code?

cjlarose commented 3 years ago

I'll take a look. It's an old issue, so this might already be fixed, but we can at least improve our docs with recommendations.