rubycorns / rorganize.it

A web app to coordinate railsgirls project groups
https://rorganize.it
GNU Affero General Public License v3.0
41 stars 23 forks source link

Don't allow http connections during specs #579

Closed vsmart closed 6 years ago

vsmart commented 6 years ago

This disables http connections when running specs to ensure tests are run against the fixtures, not the live apis. Our tests shouldn't depend on the reachability of the apis to work.

Verified that it works by disabling wifi. Tests in master fail with 'could not connect to geocoding api', tests in this branch work.

lislis commented 6 years ago

til commented 6 years ago

👏 👏 👏