Group invites, closes #449

[lislis]

Is this solving an issue already in our backlog? If so, please mention which one

449

Special things about this PR to be considered

This is one of the biggest changes yet and it will take me some time to work through this.

Do you have any open Questions you need to get answered?

If you find any edge cases that should be tested, please tell me!

Please outline the areas that should be tested, if there are any:

I'll introduce the concept of an invite. Invites are temporary relationships between a person and a group, similar to memberships but, well, temporary. A user request membership to a group, an invite is created. A group member either accepts or rejects it. Both actions destory the invite with the only difference being that accept also creates a membership.

So far the plan. I had some other ideas, that's why the model is a bit weird, not sure if I keep it or throw it out.

[lislis]

Ok, so here is a rundown of the current workflow with screenshots

• Til Example logs in an on The Rubycorns page clicks the request membership button
• After clicking, there is confirmation that membership has been requested with timestamp (no screenshot)
• On Til's profile page there is a list with pending invitations
• The Rubycorns get an email that Til has requested memberhship
• Lisa Another Coach (who is group admin) logs into RoRganize and goes to the Rubycorns group pages and sees the badge 1 at Manage members
• On the Manage members page is a section with membership requests, where Til's request can be accepted or rejected
• Depending on whether Til gets accepted or rejected they get an email and (in case of accept) become a group member

[lislis]

Updates! :tada: I added feature tests, but the invites controller #destory spec is not working the way I want it to. Can someone have a :eyes: ? Other than that I think this is ready to be reviewed! Comments welcome!

Here are the updated screens

Request membership

Membership requested

pending memberships on profile page

New membership request when group admin

Manage requests when group admin

Emails are the same

[lislis]

Ok, so now it's the fun time where tests pass locally but weird errors appear on Travis

[lislis]

I don't know why the errors are now appearing and also in tests I haven't touched. Could it be that Travis is installing another version of some dependency or something strange like that? Anybody up for debugging?

[lislis]

So, I cleared all the caches on Travis and locally and still the same: local passing, Travis failing. I'm out of ideas how I could reproduce the errors. @til @PragTob any ideas?

[lislis]

Yay, @vsmart figured out what caused the Travis error! Apparently I deleted a part of the vcr_cassette for groups which then caused the geocoder to fail on all tests that involved creating groups. Resorting that cassette from master fixed the issue! :tada:

[sareg0]