rubyforgood / Flaredown

Flaredown web app and API
http://www.flaredown.com
GNU General Public License v3.0
39 stars 15 forks source link

Fix console errors when entering birth date #496

Closed bklang closed 3 years ago

bklang commented 3 years ago

Resolves this error:

Assertion Failed: {{power-select}} If you want the default filtering to work on options that are not plain strings, you need to provide `searchField`

The problem is that the search field is expecting strings, but we are passing numbers. This is documented as a requirement by Ember in the section "Customizing the search field" Screen Shot 2021-10-13 at 10 31 35 AM

bklang commented 3 years ago

Putting this one on hold. I've only been able to show the issue in local dev. For some reason, it is not appearing in the staging environment. I'll hold off shipping this unless/until we see it in staging.

haydenrou commented 3 years ago

@bklang I totally didn't see this PR until now and made the same change here! Let me know if you want me to revert it in that PR. I don't see turning these to a string hurting however if there is no need to then I guess we can revert it.

bklang commented 3 years ago

We'll include this with @haydenrou 's work. Closing.