search

rubyforgood / Flaredown

Flaredown web app and API
http://www.flaredown.com
GNU General Public License v3.0
39 stars 15 forks source link

Add weather to existing export #517

Closed haydenrou closed 3 years ago

haydenrou commented 3 years ago

I wasn't sure if #414 called for a new export job or adding to the existing. Since it was simpler, I just added it to the existing one - however I can make a new report if that is more desirable @compwron

Update - #414 is done in #526

haydenrou commented 3 years ago

A good note pointed out by @bklang that these notes could malform this CSV. I'm going to move the notes into a different export job + PR, and this one can be just for the weather.

benlangfeld commented 3 years ago

You'll need to merge master into this PR to get CI to run properly again.

bklang commented 3 years ago

I want to add specs to cover weather exports, but I'm temporarily blocked by #535