rubyforgood / Flaredown

Flaredown web app and API
http://www.flaredown.com
GNU General Public License v3.0
39 stars 15 forks source link

Fix uninitialized constant issue #541

Closed codemonium closed 3 years ago

codemonium commented 3 years ago

This changeset resolves the issue shown in https://gist.github.com/codemonium/4723d382e867ce5bc6ebb51dee38f37d, reproducible when viewing the chat. E.g.,

uninitialized constant Api::V1::PostSerializer::Notificatable

Since we recently namespaced the serializers (https://github.com/rubyforgood/Flaredown/commit/25976d1a7be28d1c8766a246baf17e612b26bfb2), they were no longer able to find the concerns. The solution is to be more explicit when using the concerns.

benlangfeld commented 3 years ago

Sorry, I forgot to test in production mode locally.

It's so dangerous to work on an app without per-PR review envs.