rubyforgood / Flaredown

Flaredown web app and API
http://www.flaredown.com
GNU General Public License v3.0
39 stars 15 forks source link

Upgrade sass to support Node 16+ #677

Closed hussam-i-am closed 1 year ago

hussam-i-am commented 1 year ago

This pull request to the frontend package updates dependencies and package versions, and uses the sass:math module to update variable and property calculations in various SCSS files.

Tonkpils commented 1 year ago

✨ this looks straight forward although I'm not super familiar with the upgrade process for sass. It looks like there's some deprecation notices in the CI run https://github.com/rubyforgood/Flaredown/actions/runs/6397479951/job/17365494297?pr=677#step:6:33

Would you mind addressing those?

It's encouraging that all tests seems to pass now for all the node versions. I'll give this a spin locally and in staging to see if things are working as expected and get back to you when I do 🙇

hussam-i-am commented 1 year ago

@Tonkpils I believe the notices are for usages from within bower_components for bourbon/neat. I tried upgrading/porting those to npm but didnt have much luck. Will try again as a followup PR, but figured to leave this as is so it could move ahead independently