Closed CovenantHuman closed 5 months ago
This issue has been open without changes for a long time! What's up?
This does not seem to be an urgent ask
I'd like to work on this one.
I can work on this : )
This issue has been inactive for 268 hours (11.17 days) and will be unassigned after 92 more hours (3.83 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
Still working on this. Finished the feature and have finished the request test. Working on the system test now.
: )
On Sat, Jul 8, 2023 at 5:20 PM github-actions[bot] @.***> wrote:
This issue has been inactive for 268 hours (11.17 days) and will be unassigned after 92 more hours (3.83 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
— Reply to this email directly, view it on GitHub https://github.com/rubyforgood/casa/issues/2523#issuecomment-1627552856, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR3VCDK25SWQEKPA7F5QRK3XPH2L7ANCNFSM5DMOBHEA . You are receiving this because you were assigned.Message ID: @.***>
hey @elhalvers, thanks for working on this! @bcastillo32 and I have just finalized the design for this functionality! Please see below for how to implement the UI and let me know if you have any questions!
Please refer to the Figma file to see how the UI should look and how the UX should function. The below acceptance criteria represent this same behavior in checklist form.
Figma link PS: Log into Figma to leave comments, and I will respond to them!
Table overview
Row checkbox functionality
Manage Volunteers Button (On-click)
@MalloryPriceDesign these look great! @elhalvers and/or @ShamiTomita please refer to the designs and acceptance criteria and reach out if you have any questions :)
I created a new issue a while back before I saw this one (https://github.com/rubyforgood/casa/issues/4873)
Thanks @MalloryPriceDesign and @bcastillo32 !! 🥳😄
I am adding @jamgar to help with this issue/project. James is also with AOL and has been doing some awesome CASA work! @ShamiTomita and I have been selected as the junior leads to build the Rails World Conference app which will take a bit of my active attention and focus so I am happy to bring on James for additional help on this! : )
@elhalvers great! @jamgar happy to continue working with you! :)
🙌 😃
On Thu, Jul 13, 2023 at 3:10 PM Brando @.***> wrote:
@elhalvers https://github.com/elhalvers great! @jamgar https://github.com/jamgar happy to continue working with you! :)
— Reply to this email directly, view it on GitHub https://github.com/rubyforgood/casa/issues/2523#issuecomment-1634983188, or unsubscribe https://github.com/notifications/unsubscribe-auth/AR3VCDOMXNGCBSHIKAEQ5HLXQBW6TANCNFSM5DMOBHEA . You are receiving this because you were mentioned.Message ID: @.***>
This is the same as https://github.com/rubyforgood/casa/issues/4873 ??
This is the same as #4873 ??
It looks like it! : )
yes, they are the same. I didn't find this one when I made #4873
@bcastillo32 can you close one of these tickets? Not sure which one is better described.
@bcastillo32 can you close one of these tickets? Not sure which one is better described.
done. I closed the other one.
Update: Making progress on this. I had a blocker with not knowing JQuery Datatable which is used to give the table sort/filter capabilities. They have a checkbox extension that I added to give the functionality for select/unselect all.
This issue has been inactive for 252 hours (10.50 days) and will be unassigned after 108 more hours (4.50 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
This issue has been inactive for 372 hours (15.50 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.
Hi @bcastillo32 this is completed with one exception, which is I could not get the box shadow to work on hover of row. Instead I added a background color change on hover so we could get this feature completed. Any attempt to get the correct shadow effect was not working. I am not sure why but suspect that the way the tables are being created it is taking precedence on the styles. The project is using jquery datatables plugin which auto generates the tables on page request. As a side note, what I have found durning my research is that under normal circumstances adding box shadow to a table element can be a bit of a hack. If this is a hard set requirement then I would recommend opening another issue to address just the that style so that someone with CSS ninja skills :D can help.
Please see PR https://github.com/rubyforgood/casa/pull/5144
This issue has been inactive for 251 hours (10.46 days) and will be unassigned after 109 more hours (4.54 days). If you have questions, please
If you are still working on this, comment here to tell the bot to give you more time
This issue has been inactive for 371 hours (15.46 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.
Can i take it?
Can i take it?
Hi @gorangorun we have a PR for this already bu thank you for the offer - we have some other tickets that could use some love :)
I think this has been solved.
What type(s) of user does this feature affect?
Description Currently, volunteers must be assigned to supervisors one at a time. We would like to make a way for multiple volunteers to be assigned to a supervisor at a time.
Please refer to the Figma file to see how the UI should look and how the UX should function. The below acceptance criteria represent this same behavior in checklist form.
Figma Figma link PS: Log into Figma to leave comments, and Mallory (our design lead) will respond to them!
Acceptance Criteria Table overview
Row checkbox functionality
Manage Volunteers Button (On-click)
QA Login Details:
Link to QA site
Login Emails:
password for all users: 12345678