search

rubyforgood / casa

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.
https://casavolunteertracking.org/
MIT License
302 stars 467 forks source link

Figure out if FontAwesome is needed for new theme branch #4551

Closed FireLemons closed 1 year ago

FireLemons commented 1 year ago

Description There is a css library fontawesome that contains a font for icons. I think the plainadmin theme has its own icons so we won't need it anymore.

Figure out if fontawesome is needed for anything. If it's not needed, remove the dependency.

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

FireLemons commented 1 year ago

CC: @seanmarcia Not required for merge

anshu1992 commented 1 year ago

Hey @FireLemons and @seanmarcia , while working on the new theme, I came across this. I suggested using FontAwesome because the plain admins' LineIcon is very limited. Sometimes even basic icons were missing and I had to resort to closest looking icons available in LineIcons. FontAwesome is also widely used, so the contributors are also familiar with FontAwesome.

FireLemons commented 1 year ago

lets keep it