rubyforgood / casa

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.
https://casavolunteertracking.org/
MIT License
314 stars 478 forks source link

Bug: Flaky Test Did not Recieve Confirmation Text After Re-Sending an invitation to an Admin #5123

Closed FireLemons closed 6 months ago

FireLemons commented 1 year ago

Flaky tests are defined as tests that return both passes and failures despite no changes to the code or the test itself Fix the test so it runs consistently.

CI Workflow

rspec in docker

Sample Error Output:

  2) casa_admins/edit can resend invitation to a another admin
     Failure/Error: expect(page).to have_content("Invitation sent")
       expected to find text "Invitation sent" in "Inbox\nSupervisors\nVolunteers\nOther Duties\nCases\nAdmins\nGroup Actions\nMenu\nUser 1735\nEdit Casa Admin\nEmail\nDisplay name\nPhone number\nEmail Reimbursement Requests\nCASA organization CASA Org 1316\nAdded to system August 16, 2023\nInvitation email sent never\nLast logged in never\nInvitation accepted never\nPassword reset last sent never\nWill receive reimbursement request emails No\nAdmin is\nACTIVE\nDeactivate Resend Invitation Change to Supervisor\nSubmit\n© CASA / Volunteer Tracking\nBuilt with by Ruby For Good\nReport a site issue\nSMS Terms & Conditions"

     # ./spec/system/casa_admins/edit_spec.rb:105:in `block (2 levels) in <top (required)>'
     # /usr/local/bundle/gems/webmock-3.18.1/lib/webmock/rspec.rb:37:in `block (2 levels) in <top (required)>'

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

github-actions[bot] commented 1 year ago

This issue has been open without changes for a long time! What's up?

compwron commented 6 months ago

I am closing this as old. We may bring it back in a different form.