rubyforgood / casa

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.
https://casavolunteertracking.org/
MIT License
314 stars 478 forks source link

Bug: Flaky Test Did not Recieve Confirmation Text After Changing Supervisor to Admin #5129

Closed FireLemons closed 1 year ago

FireLemons commented 1 year ago

Flaky tests are defined as tests that return both passes and failures despite no changes to the code or the test itself Fix the test so it runs consistently.

CI Workflow

rspec in docker

Sample Error Output:

  1) supervisors/edit logged in as an admin can convert the supervisor to an admin
     Failure/Error: expect(page).to have_text("Supervisor was changed to Admin.")
       expected to find text "Supervisor was changed to Admin." in "Inbox\nSupervisors\nVolunteers\nOther Duties\nCases\nAdmins\nGroup Actions\nMenu\nUser 2261\nEditing Supervisor\nEmail\nDisplay name\nPhone number\nEmail Reimbursement Requests\nCASA organization CASA Org 1731\nAdded to system August 2, 2023\nInvitation email sent never\nLast logged in never\nInvitation accepted never\nPassword reset last sent never\nWill receive reimbursement request emails No\nSupervisor is ACTIVE Deactivate Supervisor Resend Invitation Change to Admin\nSubmit\nManage Volunteers\n\nAssign a New Volunteer\nSelect a Volunteer\n           Assign Volunteer\nThere are no active, unassigned volunteers available.\n© CASA / Volunteer Tracking\nBuilt with by Ruby For Good\nReport a site issue\nSMS Terms & Conditions"

     # ./spec/system/supervisors/edit_spec.rb:131:in `block (3 levels) in <top (required)>'

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

tonyaraujop commented 1 year ago

Hello there, can I work on this one?

github-actions[bot] commented 1 year ago

This issue has been inactive for 252 hours (10.50 days) and will be unassigned after 108 more hours (4.50 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time