Make Double Language Add Error Message Full Width of Parent

rubyforgood / casa

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.

https://casavolunteertracking.org/

MIT License

290 stars 464 forks source link

Make Double Language Add Error Message Full Width of Parent #5178

Open FireLemons opened 10 months ago

FireLemons commented 10 months ago

What type(s) of user does this feature affect?

volunteers

Description

Go to page /users/edit. Input some invalid values for name or email (such a blank inputs) and press update. You get an error.

Make the error shown below the width of the parent container with some margin.

Screenshots of current behavior

How to access the QA site

Login Details:
Link to QA site

volunteer1@example.com view site as a volunteer
supervisor1@example.com view site as a supervisor
casa_admin1@example.com view site as an admin
all_casa_admin1@example.com view site as an all casa admin
- go to /all_casa_admins/sign_in

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack https://rubyforgood.herokuapp.com/ #casa channel to ask questions quickly and hear about office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

jp524 commented 10 months ago

I would like to help with this issue

mattpettenato commented 10 months ago

I would love to work on this if possible!

mattpettenato commented 9 months ago

@FireLemons @schoork does this look correct? Is there anything I should change?

github-actions[bot] commented 9 months ago

This issue has been inactive for 241 hours (10.04 days) and will be unassigned after 119 more hours (4.96 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

mattpettenato commented 9 months ago

waiting for response

schoork commented 9 months ago

@mattpettenato Honestly not sure. But that does look right. Did you check mobile views, too?

github-actions[bot] commented 9 months ago

This issue has been inactive for 252 hours (10.50 days) and will be unassigned after 108 more hours (4.50 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] commented 8 months ago

This issue has been inactive for 373 hours (15.54 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

mattzollinhofer commented 8 months ago

@mattpettenato seems like it's pretty close if it's not already there. Do you have a PR to take a look at?

atbalaji commented 7 months ago

Hi, I would love to work on this. I have some doubts. Shall we discuss here or at the slack channel?

These are my doubts

Can we show the add languages option only if there are languages remaining to select other than volunteer's current languages ?
Also, in case of showing the languages list we can avoid listing the current languages of volunteer thus eliminating the need for this error message altogether.

Can i proceed along this line?

atbalaji commented 6 months ago

Commenting for follow up. Is this issue still available to work on? @mattzollinhofer

github-actions[bot] commented 4 months ago

This issue has been open without changes for a long time! What's up?

github-actions[bot] commented 6 days ago

This issue has been open without changes for a long time! What's up?