rubyforgood / casa

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.
https://casavolunteertracking.org/
MIT License
304 stars 472 forks source link

Bug: Fix Month Active User (MAU) Line Chart Data by User Type #5723

Closed sarvaiyanidhi closed 4 months ago

sarvaiyanidhi commented 4 months ago

On the /health page, We are currently showing Monthly Active User chart data based on current_sign_in_at field which is not correct as it does not logs history of user sign in.

Need to fix chart data by fetching details from new table login_activity which tracks history of User's login to calculate correct details to get Monthly Active User data. Make sure the endpoint is accessible to users who are logged out.

If chart creation fails, display an error to the user explaining why. Print a detailed version of the error in the console.

No testing required but prove your solution works.

See:

https://github.com/rubyforgood/casa/blob/main/app/controllers/health_controller.rb https://github.com/rubyforgood/casa/blob/main/app/javascript/src/display_app_metric.js

We use chart.js for graphs

See: https://github.com/rubyforgood/casa/wiki/Working-with-Frontend-Assets

More details in issue #5530

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

sarvaiyanidhi commented 4 months ago

Hi @bcastillo32 Can you please assign me this issue? In this issue I have raised separate PR to fix data shown currently on Month Active Users chart displayed in health page.