rubyforgood / casa

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.
https://casavolunteertracking.org/
MIT License
304 stars 472 forks source link

Uncap submissions for Additional Expenses and improve UX #5773

Closed elasticspoon closed 1 month ago

elasticspoon commented 4 months ago

What type(s) of user does this feature affect?

Description

If an org has enabled additional expenses the last step of the case contact form (case_contacts/:id/form/expenses) allows the volunteer to add additional expenses.

Image

Currently there is a cap of 10 expenses. When you hit 10 the button remains but you cannot add any more.

Image

We have https://www.stimulus-components.com/docs/stimulus-rails-nested-form/ in the application. It could potentially be of use (unless needed I would suggest using the non-extended version of the stimulus controller).

Completion Criteria:

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

shacon commented 3 months ago

I would like to work on this!

github-actions[bot] commented 3 months ago

This issue has been inactive for 240 hours (10.00 days) and will be unassigned after 120 more hours (5.00 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

shacon commented 2 months ago

This issue has been inactive for 240 hours (10.00 days) and will be unassigned after 120 more hours (5.00 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

Still working on this!

github-actions[bot] commented 2 months ago

This issue has been inactive for 262 hours (10.92 days) and will be unassigned after 98 more hours (4.08 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

github-actions[bot] commented 2 months ago

This issue has been inactive for 382 hours (15.92 days) and is past the limit of 360 hours (15.00 days) so is being unassigned.You’ve just been unassigned from this ticket due to inactivity – but feel free to pick it back up (or a new one!) in the future! Thank you again for your contribution to this project.

shacon commented 2 months ago

pr for this has updated changes: https://github.com/rubyforgood/casa/pull/5908/files