rubyforgood / casa

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.
https://casavolunteertracking.org/
MIT License
314 stars 478 forks source link

export all data generates a file when the filter modal is close even if close with X rather than generate #5795

Closed elasticspoon closed 4 months ago

elasticspoon commented 5 months ago

What type(s) of user does this feature affect?

Description

One of the biggest features that sets our application apart from the competitors is that we do not have any user lock in. We make all user data available for export if they so desire at /reports.

Here you can filter the columns to export.

Image

However, if you exit out of the modal it still generates the report, even if you haven't clicked generate. We should fix this.

Criteria for Completion

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

Naraveni commented 5 months ago

Can I work on this

Naraveni commented 5 months ago

Can I work on this please

elasticspoon commented 5 months ago

@Naraveni go for it

github-actions[bot] commented 5 months ago

This issue has been inactive for 261 hours (10.88 days) and will be unassigned after 99 more hours (4.13 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

Naraveni commented 5 months ago

i working on it

github-actions[bot] commented 4 months ago

This issue has been inactive for 253 hours (10.54 days) and will be unassigned after 107 more hours (4.46 days). If you have questions, please

If you are still working on this, comment here to tell the bot to give you more time

Naraveni commented 4 months ago

I already raised the pr

Naraveni commented 4 months ago

https://github.com/rubyforgood/casa/pull/5866