rubyforgood / casa

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.
https://casavolunteertracking.org/
MIT License
286 stars 458 forks source link

Fix Contact Type Select Styles Issue #5759 #5830

Closed logtay closed 1 week ago

logtay commented 2 weeks ago

What github issue is this PR for, if any?

Resolves #5759

What changed, and why?

The first letter in the dropdown is now in line with the rest of the word so that options are properly selected. Only the first letter of the searched contact type was getting selected, which would make it difficult for users to read. These changes affect the casa_cases and case_contacts pages

How is this tested? (please write tests!) 💖💪

Note: if you see a flake in your test build in github actions, please post in slack #casa "Flaky test: " :) 💪 Note: We love capybara tests! If you are writing both haml/js and ruby, please try to test your work with tests at every level including system tests like https://github.com/rubyforgood/casa/tree/main/spec/system

Changes were only made to CSS, so I did not create any new tests.

Screenshots please :)

Run your local server and take a screenshot of your work! Try to include the URL of the page as well as the contents of the page.

Screen Shot 2024-06-10 at 19 28 03 Screen Shot 2024-06-10 at 19 28 47

Feelings gif (optional)

What gif best describes your feeling working on this issue? https://giphy.com/ How to embed: alt text

logtay commented 2 weeks ago

Thank you for the feedback! I will make those changes

elasticspoon commented 1 week ago

@logtay hey, sorry I explained really poorly. I'm not tryna jerk you around or anything. :slightly_frowning_face:

when i said

Since you added app/assets/stylesheets/shared/tomselect_additional_styles.scss. We no longer need app/assets/stylesheets/pages/casa_cases.scss or app/assets/stylesheets/pages/case_contacts_form.scss.

I didn't mean for you to delete the entire files, I meant just the changes you made to them. So basically all this PR needs to contain is the line that imports the new stylesheet + the new stylesheet.

logtay commented 1 week ago

@elasticspoon It's okay, I think I misread. I thought I got rid of those first changes, but had some issues on my end, so probably overlooked it. Let me go ahead and do that. Thank you for your patience, I appreciate it.