rubyforgood / casa

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.
https://casavolunteertracking.org/
MIT License
286 stars 458 forks source link

Fix/5756 fix fund request styling #5833

Closed josephmsmith closed 1 week ago

josephmsmith commented 2 weeks ago

What github issue is this PR for, if any?

Resolves #5756

What changed, and why?

Edited the styling of the new fund request button to adhere with the styling of other buttons on casa case details.

On different size screens button would appear misaligned with the rest of the header and didn't follow the same formatting as well.

How is this tested? (please write tests!) 💖💪

This was tested by viewing in different browsers with @elasticspoon and @FireLemons

Screenshots please :)

casaNewFundRequestBtnDesktop casaNewFundRequestBtnMobile casaNewFundRequestBtnTablet

Feelings gif (optional)

![accomplished](https://giphy.com/clips/happy-dance-jim-bean-iphystudiosoriginals2022-Cn3ps2wHeWdhCRy0wy)

josephmsmith commented 2 weeks ago

@elasticspoon @FireLemons any thoughts on the test failure? Running locally I didn't have this error.

compwron commented 2 weeks ago

Test failure is

Failures:

  1) CasaOrg generate_defaults generates default contact type groups matches default contact type groups
     Failure/Error: example.run

     ActiveRecord::StatementInvalid:
       PG::UnableToSend: insufficient data in "T" message
     # ./spec/rails_helper.rb:84:in `block (2 levels) in <top (required)>'
     # ------------------
     # --- Caused by: ---
     # PG::UnableToSend:
     #   insufficient data in "T" message
     #   ./spec/rails_helper.rb:84:in `block (2 levels) in <top (required)>'

Finished in 5 minutes 26 seconds (files took 8.94 seconds to load)
2806 examples, 1 failure, 10 pending
FireLemons commented 1 week ago

:medal_sports: