fix SupervisorsController#datatable N+1 issues

[elasticspoon]

What type(s) of user does this feature affect?

• supervisors
• admins
• volunteers

Description

This controller action has issues with N+1 queries (method call makes an additional method call for each item it finds.)

You can see these in our scout: https://scoutapm.com/shares/cd70c473-d304-4df7-84e1-1b7c519aa4e9

Go through all the methods to ensure all the needed data is preloaded in the first query and no additional calls to the database need to be made.

N+1 Resources

• sample PR https://github.com/rubyforgood/casa/pull/5868
• https://guides.rubyonrails.org/active_record_querying.html#eager-loading-associations
• https://medium.com/doctolib/how-to-find-fix-and-prevent-n-1-queries-on-rails-6b30d9cfbbaf
• https://github.com/flyerhzm/bullet?tab=readme-ov-file#log

How to access the QA site

Login Details:
Link to QA site

Login Emails:

• volunteer1@example.com view site as a volunteer
• supervisor1@example.com view site as a supervisor
• casa_admin1@example.com view site as an admin
• all_casa_admin1@example.com view site as an all casa admin
  • go to /all_casa_admins/sign_in

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

[guswhitten]

@elasticspoon I can take this one.