rubyforgood / casa

Volunteer management system for nonprofit CASA, which serves foster youth in counties across America.
https://casavolunteertracking.org/
MIT License
304 stars 472 forks source link

fix CasaCasesController#show N+1 issues #5892

Closed elasticspoon closed 2 months ago

elasticspoon commented 2 months ago

What type(s) of user does this feature affect?

Description

This controller action has issues with N+1 queries (method call makes an additional method call for each item it finds.)

You can see these in our scout: https://scoutapm.com/shares/e7dee11b-72d2-4e94-b6b2-853908ded0a8

Go through all the methods to ensure all the needed data is preloaded in the first query and no additional calls to the database need to be made.

N+1 Resources

How to access the QA site

Login Details:
Link to QA site

Login Emails:

password for all users: 12345678

Questions? Join Slack!

We highly recommend that you join us in slack #casa channel to ask questions quickly. And discord for office hours (currently Tuesday 5-7pm Pacific), stakeholder news, and upcoming new issues.

Kerman07 commented 2 months ago

I can take this one.