rubyforgood / homeward-tails

Homeward Tails is an application making it easy to link adopters/fosters with pets. We work with grassroots pet rescue organizations to understand how we can make the most impact.
MIT License
69 stars 117 forks source link

Staff can upload and remove images for a pet #259

Closed kasugaijin closed 10 months ago

kasugaijin commented 1 year ago

As staff I can navigate to pet/show and go to the files tab to add a new file and delete an existing file

Acceptance criteria

torresga commented 1 year ago

May I work on this, please?

kasugaijin commented 1 year ago

All yours! @torresga

torresga commented 1 year ago

Hi there @kasugaijin , as I am looking at this further, I realize this task is potentially blocked by https://github.com/rubyforgood/pet-rescue/issues/256 and https://github.com/rubyforgood/pet-rescue/issues/257 since they all involve first creating the tab functionality. I see that there is this PR https://github.com/rubyforgood/pet-rescue/pull/265/files that creates the tabs using partials and the nice_partials gem that you already agreed to. Should I base my work on that PR? That way the scope of this ticket can just be adding the Files partial, and I won’t have to worry about re-implementing the tabs. Thanks!

kasugaijin commented 1 year ago

@torresga yes good catch! I hope to get around to reviewing that PR in a bit and then we can get it merged in so it can unblock this work.

kasugaijin commented 1 year ago

@torresga I took a look at https://github.com/rubyforgood/pet-rescue/pull/265 and like the approach. I'll await @ErinClaudio for when he is ready for review so we can merge (no rush!).

github-actions[bot] commented 1 year ago

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] commented 12 months ago

Automatically unassigned after 7 days of inactivity.

github-actions[bot] commented 10 months ago

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.