Give pet status column more contrast in the pets index table

rubyforgood / homeward-tails

Homeward Tails is an application making it easy to link adopters/fosters with pets. We work with grassroots pet rescue organizations to understand how we can make the most impact.

MIT License

69 stars 117 forks source link

Give pet status column more contrast in the pets index table #325

Closed kasugaijin closed 1 year ago

kasugaijin commented 1 year ago

The status column shows if pets are active or inactive for adoption/fostering. It is currently hard to read the white text on that colour background.

Acceptance criteria

change the background colour to something with more contrast for the white text eg. Gray 700 here: https://geeksui.codescandy.com/geeks/docs/colors.html

MooseCowBear commented 1 year ago

I can do this.

MooseCowBear commented 1 year ago

This is unrelated to issue #325, but while I was working on it I noticed there is kind of an awkward margin happening in the dashboard layout, highlighted in this screenshot.

I found the source of the margin and with a minor change that doesn't appear to affect any functionality could remove it, as in:

This does affect the mobile view slightly, but not in an objectionable way.

Before the change:

And after:

Is this change something you would be interested in?

Sorry if this is not the right place to bring this up.

kasugaijin commented 1 year ago

@MooseCowBear yes this is something that needed a fix :) it was apparently happening on some machines and not others. Could you make a separate PR for that UI change? That would be great.

MooseCowBear commented 1 year ago

Will do.