User only sees one error under input when form submit validation fails for edit registration

[kasugaijin]

Currently if you go to User > edit registration and make an error in the form e.g., password and submit, it renders an error at the top of the form AND under the input field. We only want an error under the input field (using bootstrap_form_for. This should also apply for an attachment e.g., if you try to attach a pdf file, an error should display under the attachment input.

[atbalaji]

I would like to work on this issue @kasugaijin

[atbalaji]

Hi @kasugaijin , few questions to clarify,

• Are we removing the top error part across the app to have a uniform ui?

• The top error part removal has been handled by removing https://github.com/rubyforgood/pet-rescue/blob/7261dc0b8a06632507845e78bfc929cd003a89cd/app/views/devise/registrations/edit.html.erb#L14 .

• I encountered something else, on providing a random pdf file as attachment for picture, I am encountering the following error ActionController::UrlGenerationError at /users No route matches {:action=>"purge", :controller=>"attachments", :id=>nil}, missing required keys: [:id] here. Should we create a separate issue for that?

Shall I make a PR with only the removal change?

[kasugaijin]

Hi @atbalaji Yes please remove the top error only. As part of this issue, we should display the error below the input field for the attachment. As an example, enter a wrong password and submit the form and you will see the password field is highlighted in red with an error.

As for the pdf issue, I just merged a fix for that so please merge main into your branch and that should be resolved.

[atbalaji]

Ok @kasugaijin . I have a doubt here . This fixes the issue . But I am having a doubt of should I leave validates :append_avatar as it is or should i change this validation to validate and add custom methods and check all conditions in it since :append_avatar is a method. Before raising PR wanna know your thoughts

[kasugaijin]

@atbalaji I think it is OK to just use validates and set the conditions therein. It is also how we handle other attachments e.g. on Pet https://github.com/rubyforgood/pet-rescue/blob/main/app/models/pet.rb

[atbalaji]

Done and raised PR : https://github.com/rubyforgood/pet-rescue/pull/435

[atbalaji]

I'm pleased to inform that the pull request (#435 ) has been successfully merged. The changes have been incorporated, and everything looks good.

Considering this, could we kindly close this issue now?

[kasugaijin]

For sure @atbalaji thanks for the reminder.