rubyforgood / human-essentials

Human Essentials is an inventory management system for diaper, incontinence, and period-supply banks. It supports them in distributing to partners, tracking inventory, and reporting stats and analytics.
https://humanessentials.app
MIT License
464 stars 493 forks source link

Cleanup on admin_ paths #3991

Closed cielf closed 7 months ago

cielf commented 10 months ago

Summary

Admin paths currently require a organization_id, which is the short_name. Unless actually dealing with an organization, they shouldn't. Also address the mismatch between the parameter name and what is used.

Why fix

Confusion. Current solution is kludgey (having to hackishly send a faux short name to get to admin things)

Details

Admin paths currently require a organization_id, which is the short_name.
Unless actually dealing with an organization, they shouldn't.
Also address the mismatch between the parameter name (organization_id) and what is used (short_name).

Notes

Origin of issue

See discussion on https://github.com/rubyforgood/human-essentials/pull/3664

Criteria for completion

github-actions[bot] commented 9 months ago

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] commented 8 months ago

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] commented 8 months ago

Automatically unassigned after 7 days of inactivity.