search

rubyforgood / human-essentials

Human Essentials is an inventory management system for diaper, incontinence, and period-supply banks. It supports them in distributing to partners, tracking inventory, and reporting stats and analytics.
https://humanessentials.app
MIT License
447 stars 474 forks source link

Revert "Revert "feat(#3345): serve last user role on login"" #4291

Closed cielf closed 5 months ago

cielf commented 5 months ago

Reverts rubyforgood/human-essentials#4290

cielf commented 5 months ago

I inattentively merged the change for serve most recent role -- it must have had a failing test, because it certainly does now (It had been approved, but there was a merge of main into it after).

elasticspoon commented 5 months ago

the failing CI spec was https://github.com/rubyforgood/human-essentials/actions/runs/8767044637/job/24059850517

which has been flaky for a bit (https://github.com/rubyforgood/human-essentials/issues/4248). Do you any more info on what the errors on staging or after the merge?

cielf commented 5 months ago

@dorner I'm not sure how close #4248 is to fruition. We could just merge this and accept that that test is really flakey and might need a few tries to get through, or we could wait for it if it's close. Your call .

dorner commented 5 months ago

@cielf why was it reverted? Just because of the failing test? If so, there's no reason not to merge this. But I thought there was some login issue reported by users, and we reverted this because of that?

cielf commented 5 months ago

Just because of the test failing 3 times. So I think it can go forward.

dorner commented 5 months ago

Re-merged!

github-actions[bot] commented 5 months ago

@cielf: Your PR Revert "Revert "feat(#3345): serve last user role on login"" is part of today's Human Essentials production release: 2024.04.28. Thank you very much for your contribution!