rubyforgood / human-essentials

Human Essentials is an inventory management system for diaper, incontinence, and period-supply banks. It supports them in distributing to partners, tracking inventory, and reporting stats and analytics.
https://humanessentials.app
MIT License
436 stars 450 forks source link

Add optional signature line to distribution printout #4312

Closed cielf closed 4 weeks ago

cielf commented 2 months ago

Summary

Some (but not all) banks use the distribution printout as a receipt, requiring a signature from the partner on pickup or delivery. Add that at the end of the printout, optionally

Details

The flag for inclusion should be on an organization level, default to false

The added lines should be (adjust to fit the 8.5 x 11 page): Received by: (Print Name) (Signature and Date) ____ Delivered by: (Print Name) (Signature and Date) ____

Note: One bank is using the comments as a workaround for this.

Criteria for completion:

sean-dickinson commented 1 month ago

I'd be happy to take this one

dorner commented 1 month ago

You got it!

sean-dickinson commented 1 month ago

@dorner I'm curious to hear what you were thinking in terms of testing this functionality. It doesn't look like there's anything currently set up for testing this pdf generation or for any other similar flag functionality on the organization. I'd be happy to test it out, but I'm not sure the best way.

dorner commented 1 month ago

Good question. Most of the functionality here is visual, which tests wouldn't be able to show. I think a minimal test that shows that the result generates, without crashing, and without any specific expectations on the output, should be fine. If we don't have that, it'd be a good idea to add it for this.