search

rubyforgood / human-essentials

Human Essentials is an inventory management system for diaper, incontinence, and period-supply banks. It supports them in distributing to partners, tracking inventory, and reporting stats and analytics.
https://humanessentials.app
MIT License
436 stars 449 forks source link

add faker for child first names in seed file #4375

Closed Trevor-Robinson closed 1 month ago

Trevor-Robinson commented 1 month ago

Resolves #4295

Description

Names for children in the seed file were using both the first and last name of the associated Guardian. Changed this to generate a random first name using faker, but left last name the same so it can be easily seen who is in the same family. Since change was only in seed file, it did not seem that any changes to tests or additional tests were needed.

Type of change

How Has This Been Tested?

Seeded database before change and viewed relevant data in postico, saw that children names for a given family all matched the guardian name. Reset database, made change and reseeded, then viewed in postico again to confirm names were no longer the same. As far as I could tell, there were no tests in the spec folder for testing the seed file.

Trevor-Robinson commented 1 month ago

Updated the code to add .unique to the first names.