search

rubyforgood / human-essentials

Human Essentials is an inventory management system for diaper, incontinence, and period-supply banks. It supports them in distributing to partners, tracking inventory, and reporting stats and analytics.
https://humanessentials.app
MIT License
436 stars 450 forks source link

Configure bank organization units #4432

Open awwaiid opened 2 weeks ago

awwaiid commented 2 weeks ago

This PR builds on #4415 and works toward #4396.

This adds partner-request-units configuration for Bank Organizations.

awwaiid commented 2 weeks ago

Thank you for looking -- I'll give it a try to get rid of the extra drop-down when in this tags mode, but I had some issue with it. I might have to go back to the more hand-built UI if I can't get it working well enough.

On Tue, Jun 11, 2024 at 1:02 PM CL Fisher @.***> wrote:

@.**** requested changes on this pull request.

I think the dropdown with the units they have used is not useful, and is potentially confusing. Can we get rid of it, please? I also notice that if you enter a unit that is a substring of an already entered unit, it won't take it (though it will accept a superstring of an already entered unit) Do I think that's going to be a problem? Probably not.

— Reply to this email directly, view it on GitHub https://github.com/rubyforgood/human-essentials/pull/4432#pullrequestreview-2111008510, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAACDQWMH5ZJACPD67TJTBTZG4URTAVCNFSM6AAAAABJAPIJMKVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMJRGAYDQNJRGA . You are receiving this because you authored the thread.Message ID: @.***>

cielf commented 1 week ago

So this is back to the more manual way, then. That seems to work.

awwaiid commented 1 week ago

@cielf Try again, I switched the target base branch for this PR. Diff is much smaller :)