cielf commented 2 weeks ago

Summary

Cleaning up a page break issue with distribution print

Why

Professionalism, makes it easier to read

The page break on distribution print is such that the line items are overlapping with the footer.

The page break needs to be adjusted so that doesn't happen.

Note that we have fixed this for the optional signature line already -- so you may be able to find the appropriate values for when to break there. (See PR https://github.com/rubyforgood/human-essentials/pull/4342)

[ ] behaviour as described above
[ ] I'm not sure this can be automatically tested easily, so please include screenshots that show the case where there are too many line items, and the case where the totals would otherwise overlap.

norrismei commented 2 weeks ago

@cielf can I give this one a try?

cielf commented 1 week ago

It's yours!