Closed jimmyli97 closed 1 week ago
Thanks!
@jimmyli97: Your PR Fix #4447 Fix #3987 Fix #3755 merge README into CONTRIBUTING and document deploy process
is part of today's Human Essentials production release: 2024.06.23.
Thank you very much for your contribution!
Resolves #4447 Resolves #3987 Together with #3766 resolves #3755
Description
bundle exec rake
andbin/lint
before pull requestsAdditional changes:
binding.pry
inrspec
for specific line numbersgit push origin tag <tagname>
instead ofgit push --tags
, see this SO post for whyMotivation
Basically what I mentioned in #4447, the duplication of guidelines is a bit confusing as well as the conflicting information about what to run before making a pull request. Also, I wanted a checklist that I could glance at to make sure I did everything correctly.
Type of change
How Has This Been Tested?
Opened README and CONTRIBUTING and SBV in browser