rubyforgood / human-essentials

Human Essentials is an inventory management system for diaper, incontinence, and period-supply banks. It supports them in distributing to partners, tracking inventory, and reporting stats and analytics.
https://humanessentials.app
MIT License
436 stars 450 forks source link

Autoscrolling when adding new items in donations/distributions/purchases/partner requests #4450

Closed jp524 closed 2 weeks ago

jp524 commented 2 weeks ago

Resolves #4440.

Description

Per issue description, when adding a new item to a donation, distribution, purchase or partner request the screen would stay in place. The users would have to scroll down to see the new item added.

This change introduces a simple fix in the Stimulus controller that adds new items.

Type of change

How Has This Been Tested?

I did some manual testing in my local development environment. Please refer to video recording below.

Screenshots

Before https://github.com/rubyforgood/human-essentials/assets/85654561/a87c0fc3-412b-4ea6-acd9-aae89bc966fb

After https://github.com/rubyforgood/human-essentials/assets/85654561/214360d3-0ced-4054-9ba8-ca0fb6b9f994

dorner commented 2 weeks ago

An automatic test for this would be much more trouble than it's worth. I'm fine as is!

github-actions[bot] commented 1 week ago

@jp524: Your PR Autoscrolling when adding new items in donations/distributions/purchases/partner requests is part of today's Human Essentials production release: 2024.06.16. Thank you very much for your contribution!