search

rubyforgood / human-essentials

Human Essentials is an inventory management system for diaper, incontinence, and period-supply banks. It supports them in distributing to partners, tracking inventory, and reporting stats and analytics.
https://humanessentials.app
MIT License
466 stars 494 forks source link

4434 remove superuser delete functionality #4480

Closed noah-puckett closed 4 months ago

noah-puckett commented 4 months ago

Resolves #4434

Description

Based on the description in this issue, I have removed the button for deleting users from the admin's user list.

While the issue description said only to remove the button, I have included a commit removing the functionality from the controller as well, which I am not certain is strictly necessary and would appreciate any feedback available.

Type of change

How Has This Been Tested?

I removed the delete button from the view, then locally ran the site and saw the button no longer rendered. I then added the button back and removed the controller logic to destroy a user, ran the site locally and clicked the delete button, which produced a The action 'destroy' could not be found for Admin::UsersController and did not delete the user.

I removed the test that asserted functionality in that controller, ran the full test suite, and all tests passed.

Screenshots

Before button removal: Screenshot 2024-06-19 at 9 10 00 AM After button removal: Screenshot 2024-06-26 at 10 20 14 AM

dorner commented 4 months ago

All good on my end - @cielf want to take a look at the UI?

cielf commented 4 months ago

Will check tomorrow.

cielf commented 4 months ago

Looks alright. Merging.

github-actions[bot] commented 4 months ago

@noah-puckett: Your PR 4434 remove superuser delete functionality is part of today's Human Essentials production release: 2024.07.07. Thank you very much for your contribution!