rubyforgood / human-essentials

Human Essentials is an inventory management system for diaper, incontinence, and period-supply banks. It supports them in distributing to partners, tracking inventory, and reporting stats and analytics.
https://humanessentials.app
MIT License
460 stars 489 forks source link

[PACKS] item units for new requests should not be set initally. #4612

Open cielf opened 2 months ago

cielf commented 2 months ago

Summary

New request for packs was implemented with a default. We need it to have no default

Why

Reduction of partner error -- some partners will do one unit, some another, within the same bank.

Details

The custom units field for the request should not be defaulted -- it should start with a 'please select...' (althernatively we could do it as a non-selected radio button group). It must, however, be selected on save if the quantity for the corresponding item is not 0.

Criteria for completion

isaiah3031 commented 2 months ago

Hey @cielf, I'd like to work on this issue. Just to clarify, this is on the new distribution form right?

cielf commented 2 months ago

Hey @isaiah3031 -- Thank you for your interest! We're really close to getting the whole PACKS milestone done, and this is on the critical path, so I've asked @awwaiid (one of our senior staff) to take it on just for speed's sake. May I suggest #4343 as an alternative?

github-actions[bot] commented 1 month ago

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] commented 3 weeks ago

Automatically unassigned after 7 days of inactivity.