search

rubyforgood / human-essentials

Human Essentials is an inventory management system for diaper, incontinence, and period-supply banks. It supports them in distributing to partners, tracking inventory, and reporting stats and analytics.
https://humanessentials.app
MIT License
464 stars 493 forks source link

[BUG] On new item, category dropdown disappears after error #4674

Open cielf opened 1 month ago

cielf commented 1 month ago

Summary

If you have an error on new item, the category list for selection disappears. It shouldn't.

Details

Recreation

login as org_admin1@example.com Select Inventory, then Items & Inventory, then Items, then New Item Click in the "Category" field. You will see a list of categories to choose from Click Save Click in the "Category" field. You no longer see a list of categories to choose from.

Hint

It's probably re-rendering without resetting up the category stuff.

Required change

The ability to select "Category" should still be available after having an error on this screen.

Criteria for completion

Noted by Gabe Torres, June 4 2024 "Thanks for posting, Daniela. It reminded me of something I noticed that also concerns forms. I thought it could have been my branch, but I tried it on main, and the issue persisted. Recreating: When logged in as a bank, navigate to http://localhost:3000/items/new Submit a blank form. Bug: The drop-down menu for category no longer functions and changes into some kind of numeric input that can be decreased or increased. I’m not sure if this is a known issue or not, but I thought I’d share."

bdeanhardt commented 1 month ago

I tackled this one! Here's my PR https://github.com/rubyforgood/human-essentials/pull/4703

princekumarg12 commented 1 month ago

Hi! @cielf I'm new to this project, and I would love to work on this issue. Looking forward to contributing!

cielf commented 1 month ago

@princekumarg12 There was already a PR in progress for this one, so I think we'll go with that one, if it works.

github-actions[bot] commented 1 week ago

This issue is marked as stale due to no activity within 30 days. If no further activity is detected within 7 days, it will be unassigned.

github-actions[bot] commented 5 hours ago

Automatically unassigned after 7 days of inactivity.

cielf commented 4 hours ago

This is in the latter cycles of the pull request review and fix.